-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
…h-enabled is set to false and all items are selected in multiple select mode.
@nabilnaffar Can you please remove the |
…en search-enabled is set to false and all items are selected in multiple select mode." This reverts commit ffcf66c.
…h-enabled is set to false and all items are selected in multiple select mode.
@aaronroberson sure! |
Thanks @nabilnaffar! |
I feel like this was a bad PR @aaronroberson -- When I type something into the search box and it returns no results from my API call, I cannot hit the backspace button. In fact, I can no longer hit any button while I have the input focused. |
Many problems with this change. Reverted it for this reason. This reverts commit 0d81493.
Added PR for reverting this maybe @nabilnaffar can have a look at the comments and make a new PR. |
@chadfurman can you specify the scenario that doesn't work + browser/OS? I'll try to reproduce it |
Is this the PR that broke release 0.19.5? I think this version should be pulled from bower etc. it is unusable for the reasons @chadfurman lists. |
With the current dist, I get this behaviour: |
For us 0.19.5 completely broke any multiple selects that have no options preset and rely on |
The tag was missing from the |
* Revert "Bug fix - Search input isn't blocked (angular-ui#1822)" Many problems with this change. Reverted it for this reason. This reverts commit 0d81493. * cleaning up comments
* fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode. * Revert "fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode." This reverts commit ffcf66c. * fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode.
* Revert "Bug fix - Search input isn't blocked (angular-ui#1822)" Many problems with this change. Reverted it for this reason. This reverts commit 0d81493. * cleaning up comments
Scenario:
expected results:
input keys should be blocked, input search should stay clean
actual results:
keyboard keys are shown in input search