Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Bug fix - Search input isn't blocked #1822

Merged
merged 3 commits into from
Oct 19, 2016

Conversation

nabilnaffar
Copy link
Contributor

Scenario:

  • multiple select
  • search-enabled is set to false
  • all items are selected
  • user type something in search input

expected results:
input keys should be blocked, input search should stay clean

actual results:
keyboard keys are shown in input search

…h-enabled is set to false and all items are selected in multiple select mode.
@aaronroberson
Copy link
Contributor

@nabilnaffar Can you please remove the dist/ files from the PR?

…en search-enabled is set to false and all items are selected in multiple select mode."

This reverts commit ffcf66c.
…h-enabled is set to false and all items are selected in multiple select mode.
@nabilnaffar
Copy link
Contributor Author

@aaronroberson sure!

@aaronroberson aaronroberson merged commit 0d81493 into angular-ui:master Oct 19, 2016
@aaronroberson
Copy link
Contributor

Thanks @nabilnaffar!

@chadfurman
Copy link

I feel like this was a bad PR @aaronroberson -- When I type something into the search box and it returns no results from my API call, I cannot hit the backspace button. In fact, I can no longer hit any button while I have the input focused.

Jefiozie added a commit to Jefiozie/ui-select that referenced this pull request Oct 23, 2016
Many problems with this change. Reverted it for this reason.
This reverts commit 0d81493.
@Jefiozie Jefiozie mentioned this pull request Oct 23, 2016
@Jefiozie
Copy link
Contributor

Added PR for reverting this maybe @nabilnaffar can have a look at the comments and make a new PR.

aaronroberson pushed a commit that referenced this pull request Oct 23, 2016
* Revert "Bug fix - Search input isn't blocked  (#1822)"
Many problems with this change. Reverted it for this reason.
This reverts commit 0d81493.

* cleaning up comments
@nabilnaffar
Copy link
Contributor Author

@chadfurman can you specify the scenario that doesn't work + browser/OS? I'll try to reproduce it

@insidewhy
Copy link

Is this the PR that broke release 0.19.5? I think this version should be pulled from bower etc. it is unusable for the reasons @chadfurman lists.

@lundens
Copy link

lundens commented Oct 24, 2016

With the current dist, I get this behaviour:
http://plnkr.co/edit/yuyks6ddYFWw1gUhnmEP?p=preview

@rthrfrd
Copy link

rthrfrd commented Oct 25, 2016

For us 0.19.5 completely broke any multiple selects that have no options preset and rely on refresh to fetch the options after the user begins typing, as the user is unable to type anything at all.

@user378230
Copy link
Contributor

The tag was missing from the 0.19.6 release for this revert so I've just pushed one to ensure bower is updated.

Jefiozie added a commit to Jefiozie/ui-select that referenced this pull request Oct 31, 2016
* Revert "Bug fix - Search input isn't blocked  (angular-ui#1822)"
Many problems with this change. Reverted it for this reason.
This reverts commit 0d81493.

* cleaning up comments
kboga pushed a commit to kboga/ui-select that referenced this pull request Nov 29, 2016
* fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode.

* Revert "fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode."

This reverts commit ffcf66c.

* fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode.
kboga pushed a commit to kboga/ui-select that referenced this pull request Nov 29, 2016
* Revert "Bug fix - Search input isn't blocked  (angular-ui#1822)"
Many problems with this change. Reverted it for this reason.
This reverts commit 0d81493.

* cleaning up comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants