Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

feat(choices): allow to set default dropdown position #1213

Merged
merged 1 commit into from
Sep 29, 2015

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Sep 29, 2015

We should be able to set dropdown position explicitly so I added a new attribute called position for the <ui-select-choices> tag, that will accept 3 values: up, down and auto

Sometimes we might not want the dropdown to go automatically up even when there isn't enough space, so now we can force position to always go to an specific direction.

Also you can specify globally at uiSelectConfig using dropdownPosition

Demo plunker

dimirc added a commit that referenced this pull request Sep 29, 2015
feat(choices): allow to set default dropdown position
@dimirc dimirc merged commit 3ab865a into master Sep 29, 2015
@dimirc dimirc deleted the fix-setting-dropdown-pos branch September 29, 2015 17:22
@isimonov
Copy link

Thanks a lot! My example works correctly http://plnkr.co/edit/Tzcp1q2WV7HZCp5meftC?p=preview

@karptonite
Copy link

This is actually not working properly for me.
http://plnkr.co/edit/NuSM3OfJUgbxCRYoln8z?p=preview
The role selector is set to position="down" and the select options go down at first, but then reverses if you type a letter, then delete it.
http://quick.as/wy2mc3zva

@dimirc
Copy link
Contributor Author

dimirc commented Sep 29, 2015

@karptonite I found the bug and will push a new patch release today

@karptonite
Copy link

@dimirc Thanks! Your work on this is certainly appreciated!

@dimirc
Copy link
Contributor Author

dimirc commented Sep 30, 2015

@karptonite v0.13.1 released and now your issue should be fixed. Check updated demo http://plnkr.co/edit/H6ZSPuZ6qnEEJAF4dFrA?p=preview

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants