-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Opening the dropdown should scroll to the selected item. #976
Comments
It should indeed scroll to the selected item. +1 |
For anyone in a pinch, the "_ensureHighlightVisible()" function is called whenever the user strikes a "vertical" key (e.g. up/down arrow). While I haven't run the tests yet, I've seen success executing the same logic inside the "ctrl.activate()" function's $timeout where focus is also set. Again, this is merely a bandaid. |
When |
same as @DerekDomino |
The PR #1208 has broken multiple selection with For instance, the user wants to select X, Y and Z. He selects X with the mouse and the dropdown goes back to A (which is the current highlighted element) |
fix(uiSelectController): fix dropdown returning to activated element The dropdown was going back to the activated element ('A' for instance) when the user clicked on the 'X' element, which was quite annoying when he wanted to select also Y and Z Closes #976
Hi guys, This does not work on Angular 1.5.7. I dont know if that is a problem. I am trying to debug the code, I dont understand at this line. Can you explain to me when 'if' statement occurred ? It always goes into 'if' condition with animate = true, so the else statement never triggered and _ensureHighlightVisible () never be called.
|
Hi, |
Hello, Here is a plunk that reproduces the issue: https://plnkr.co/edit/n9jwLCyUv87Ba3vPgOvu
1. In combination with
|
Did anyone find a solution ? I have the same problem with the same angular and ui select versions as you |
You can use the fork I made for the pull request until they release a new version: In package.json replace: The run an Fork: https://github.com/kidroca/ui-select/tree/v0.19.8-fork |
@kidroca thank you, the fork works perfectly fine. Any word from the maintainers as to when we can expect this merged/solved on master? |
Glad you like it. We almost merged the changes last week, maybe track the pull request topic to know for sure: #2034 |
Currently the drop down opens at the first item. It would be better if it scrolled to ensure the current selection is visible.
A second issue exists in that moving the mouse over the dropdown to scroll clobbers the original active item so you can no longer tell what the selected item was (when using the selectize theme).
It would probably be better if the hover state was separate from the active state as mentioned in #282.
The text was updated successfully, but these errors were encountered: