This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Optimize running dynamic width calculations when resizing
- Loading branch information
1 parent
6dfe407
commit d78ba5f
Showing
1 changed file
with
11 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d78ba5f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesleycho looks like this fix would help fix #845 (as well as several other related bugs with ng-show) if you could change one line:
sizeWatch = $scope.$watch(angular.noop, function()
to
sizeWatch = $scope.$watch(function()
This way it will try on every $digest until visible (updateIfVisible). Right now, as coded, the $watch never gets triggered again, since the watchExpression never changes (noop). This does fix it for a case we are investigating. Thanks for your consideration.