Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uiSref): fix to uiSref when using dynamic state names #1078

Closed
wants to merge 1 commit into from

Conversation

lee-tunnicliffe
Copy link

Fix to ensure href updates when the state name or the params change as
opposed to just the params.

Closes #395

Fix to ensure href updates when the state name or the params change as
opposed to just the params.

Closes angular-ui#395
@mrzepinski
Copy link

+1

@timkindberg
Copy link
Contributor

This doesn't work when I run the karma:past grunt task. Something about angular 1.0.8 doesn't run the attrs.$observe handler after the $scope.apply call. I can't seem to figure out why. I wonder if we still need to support 1.0.8?? @nateabele?

@timkindberg
Copy link
Contributor

Does this work with relative state names too? '.child.grandchild' or '^'

Also does this work with having the parameters (both key and value) be interpolated?

We should add tests for those things too.

@christopherthielen
Copy link
Contributor

@timkindberg @nateabele what say you?

@nateabele
Copy link
Contributor

(1) The mustaches look super ugly to me. I'd actually prefer something like ui-sref="[stateName, params]". (2) I'm pretty sure attrs.$observe() wasn't introduced until 1.2.x.

@nateabele
Copy link
Contributor

Closing this as we decided to roll with an alternate directive.

@nateabele nateabele closed this Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic ui-sref in directive
5 participants