Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use plugins when using the published UMD bundle #3418

Closed
christopherthielen opened this issue Apr 30, 2017 · 1 comment
Closed

Cannot use plugins when using the published UMD bundle #3418

christopherthielen opened this issue Apr 30, 2017 · 1 comment
Milestone

Comments

@christopherthielen
Copy link
Contributor

Plugins can depend on ui-router-core. However, when using the prebuilt UMD bundles, ui-router-core is bundled together with the angularjs code. When a plugin tries to use something from ui-router-core, the module is not found as nothing is found in the global scope.

There are two options I've considered:

  1. Split up the UMD modules. Publish only the AngularJS bits in angular-ui-router.min.js, and force ui-router users to also add the ui-router-core.min.js UMD bundle when they upgrade.

  2. Add an adapter that re-exports the core bits and is published as core-adapter.umd.js

I'm going move with option 2 because I don't want to force all existing users who are used to a monolithic bundle to now explicitly include ui-router-core too.

@christopherthielen christopherthielen added this to the 1.0.0-rc.2 milestone Apr 30, 2017
@christopherthielen
Copy link
Contributor Author

Fixed by dd26d49

christopherthielen added a commit that referenced this issue May 7, 2017
This enables ui-router plugin support when using script tags

Fixes #3418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant