TimePicker shows current time when model is empty.

[functionportal]

TimePicker shows current time when the model is null or cleared. On the contrary, DatePicker is blank when model is empty, which is the correct approach. It is impossible to tell when the TimePicker model is not set by looking at the control. TimePicker should be blank when model is not set.

[coolaj86]

+1

[bekos]

After looking at this one, that seems a pretty easy fix, but the question is whether this is the default behavior we want or not, because adding another configuration parameter for this seems like an overkill. Also, after #1561 is merged, we can add another directive as an alternative option, but I am not sure if it's worth the trouble. WDYT?

[toners]

In the meantime - if I was to modify the existing version locally to suit the needs of my project - how would I set this to so that it appears blank unless edited? Thanks

[bekos]

@toners At updateTemplate. Change the $scope.hours, $scope.minutes to assign only when the $modelValue is not nul, else null.

[philippd]

+1

[mhermann84]

+1

[smayer]

+1

[GFoley83]

+1

[jbthoma]

+1

[ppollono]

+1

[gogromat]

+1

[IGx89]

+1

[knicklabs]

+1

[NuNn-DaDdY]

+1

[iraj-jelo]

+1

[constellates]

+1

[mciastek]

+1

[DefeNder93]

+1

[DigitalSmile]

+1

[deggesim]

+1

[ghost]

+1

[lichtner]

+1 why don't merge this?

[szabyg]

@rvanbaalen I think I contributed to the discussion and in the last month no one responded to the points I made. Does that mean that you all agree? Shall we move on to implementation and a pull request? Who will merge it if no one feels responsible for the issue?

[fmccown]

If this would be helpful, here's my implementation of the timepicker that shows empty inputs when the given model is null.

[wesleycho]

@szabyg I will move to implement this feature behind a feature flag, opting for the default behavior to be as requested here to match the datepicker and to allow what is requested in #1589 to be possible as well.

[wesleycho]

This is a much more difficult feature to implement than I expected - to properly do this has a lot of side-effects that needs to be accounted for.

I'm not sure it is as easy as people think.

[fmccown]

You're right... it is not easy to implement. Take a look at this Plunker where I've implemented it. The only thing I'm not real happy about is that $touched is set after moving from the hour field to the minute field, but otherwise it's a pretty good start.

[wesleycho]

Mind making those changes and opening a PR? I can review it and help make it good to get in.

[fmccown]

Sure thing.

[helenev]

Do you know when the fix for this issue will be on bower?

[icfantv]

@helenev, I'm on my phone so I can't easily check. If this is in the 1.0 release, then we don't have a date yet as we have some things we need to finish up for it. Our goal is to release by the end of the year. If you want, feel free to pull master and run npm install followed by grunt to build the latest snapshot release. The generated files will be in the dist directory. Please note that this release has a TON of breaking changes so make sure you look at the changelog.

[ZackBotkin]

Was this ever fixed?

[mfsi-surajs]

+1
any workaround to clear that field when model is null ?

[joaoesantos]

Im still not able to fix this, any workaround on thsi?

[spwinner2017]

+1
I have set this.medicineForm.get('startTime').setValue(Date.now()); but its not chaging when i select another time ...