[Enhancement][REDO] ternModuleInstalls to support folders within a plug-in JAR per Issue #332 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
added a commit
that referenced
this pull request
Nov 10, 2015
[Enhancement][REDO] ternModuleInstalls to support folders within a plug-in JAR per Issue #332
|
Thanks @demonfiddler! |
|
Thanks for the merge @angelozerr. Did you have any further thoughts about removing/deprecating support for the ZIP-format repository contribution now that we can just bundle the stuff in a plug-in folder? I didn't prepare a specific test case for the latter in case you intended to remove the ZIP support, in which case we could simply modify the existing test case to suit the new packaging. |
Please do a PR for that. I think you are the first guy who is using this feature. Please update if possible the samples. |
|
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Angelo's request following his recent extensive refactoring, this is a re-submission of my Pull Request for the implementation for Issue #332.
P.S. @angelozerr I'm a total Git newbie and am not particularly confident that I have correctly used the Git CLI to fetch & merge your recent commits. Please let me know if you hit any problems.
Thanks,
--A