Use regex to search the handbook for all words separately #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramer
commented
Jan 22, 2025
Comment on lines
-152
to
-161
| public override float GetTextMatchWeight(string text) | ||
| { | ||
| /*string title = TextCacheTitle; | ||
| if (title.Equals(searchText, StringComparison.InvariantCultureIgnoreCase)) return 3; | ||
| if (title.StartsWith(searchText, StringComparison.InvariantCultureIgnoreCase)) return 2.5f; | ||
| if (title.CaseInsensitiveContains(searchText)) return 2; | ||
| if (TextCacheAll.CaseInsensitiveContains(searchText)) return 1;*/ | ||
| return 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
I did not add the same override as I was not sure of its intended purpose, but obviously it's not difficult to bring back.
There was a problem hiding this comment.
GetTextMatchWeight is intended to return weighted results based on things like titles being higher in the list than descriptions. Does your code adequately replace this weighting to make sure different things have different weights to them in the results?
There was a problem hiding this comment.
I understand the purpose of GetTextMatchWeight, I was specifically referring to the commented out code.
Yes, it sorts all pages by title matches first, then breaks ties by page content matches, and then by title length to prefer more exact matches.
c10dd7b to
0a94d1a
Compare
0a94d1a to
5eee39c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discord.com/channels/302152934249070593/351624415039193098/1331565708265390132 and https://discord.com/channels/302152934249070593/351624415039193098/1331866085313740883 for Discord discussion
This makes the search results much more intuitive. For example, "plate iron armor" actually shows the relevant armor.
One downside is that even very weak results (e. g. a single match in the page's body) are added to the list. It doesn't seem to cause significant performance issues, but might be a bit confusing. so I'm welcome to any suggestions of limiting that (e. g. at most 50 matches, but always include all results that have matches in the title).
I've tested international support only in Russian, as that was easily accessible to me, but I don't think there is any functional difference from the previous implementation there.