Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dts direct passthrough support #335
Dts direct passthrough support #335
Changes from all commits
b73d2cc
22b45b7
6823a29
c0e03f1
3b9d680
d01a93b
689451b
b069fb1
c984387
f47930e
abc46d4
753257e
b1ac768
924723d
53f35f4
773d3c5
6b4cf4d
905ad1c
cb29e8f
424b5d8
47b0726
5a6906a
d0cd2f5
c61f8d3
b9a53da
162f5e8
f69718e
9d147f2
ea32f11
48509df
fb34983
f301214
730cfec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cedricxperi We have two questions regarding this:
I'm seeing in the referenced issue, Xiaomi TV V435H is the device for reproducing the bug. Are there any more devices can reproduce it?
If DTS:X TV reporting ACTION_HDMI_AUDIO_PLUG.EXTRA_MAX_CHANNEL_COUNT as 8 instead of 10 #396 is a device problem, the issue can be fixed from their side?
The reason I'm asking above questions is - either this is a device or even platform issue, if it is able to be fixed, how do you think if we just don't attempt to play DTS:X for those devices (
isPassthroughPlaybackSupported()
will returnfalse
and DTS:X track won't be selected)? In that way this issue can be automatically solved by the device/platform without this workaround.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tianyif I do not have access to other device at the moment but it is reasonable to think that this would be reproduceable for all DTS:X TVs based on MTK platforms. It will take sometime for this issue to be fixed on the platform. Meanwhile, Xperi will have to go to each and every streaming service to tell them to add the above so that DTS:X can be played back. I think it is better to add this patch in the exoplayer code base so that everyone will be aware of it. When the issue get fixed on the platform (which could take a long time), we can remove this patch in another exoplayer contribution. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will keep this patch. Thanks!