Skip to content

Commit

Permalink
Add MP3 test asset with VBRI frame
Browse files Browse the repository at this point in the history
This was hand-crafted with a 4-entry ToC by modifying
`bear-vbr-xing-header.mp3` in a hex editor.

The output difference from 117 samples to 116 samples is due to the
calculation in `VbriSeeker` assuming that the ToC includes the VBRI
frame itself, which I don't think is correct (fix is in a follow-up
change).

Issue: #1904

#cherrypick

PiperOrigin-RevId: 700254516
(cherry picked from commit 3eb36d6)
  • Loading branch information
icbaker authored and shahdDaghash committed Nov 26, 2024
1 parent f34abbb commit 7abfa76
Show file tree
Hide file tree
Showing 7 changed files with 1,725 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ public void mp3SampleWithInfoHeaderAndTrailingGarbage() throws Exception {
simulationConfig);
}

@Test
public void mp3SampleWithVbriHeader() throws Exception {
ExtractorAsserts.assertBehavior(
Mp3Extractor::new, "media/mp3/bear-vbr-vbri-header.mp3", simulationConfig);
}

@Test
public void mp3SampleWithCbrSeeker() throws Exception {
ExtractorAsserts.assertBehavior(
Expand Down
Loading

0 comments on commit 7abfa76

Please sign in to comment.