Change predictive back NavHost implementation #105
Merged
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnohe
approved these changes
Nov 8, 2024
| scaleOut(targetScale = 0.9F) + fadeOut() | ||
| scaleOut( | ||
| targetScale = 0.9f, | ||
| transformOrigin = TransformOrigin(pivotFractionX = 0.5f, pivotFractionY = 0.5f), |
There was a problem hiding this comment.
How does transformOrigin change the animation? I don't see a difference in the animation if I leave it out.
There was a problem hiding this comment.
The default value for TransformOrigin is at the center (0.5f,0.5f). In this case, since that's our desired effect, we could leave it out, but I think leaving it in shows that it can changed to a different point.
secondsun
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the fadeOut with the scaleOut transition into the NavHost and update some library dependencies