Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gradle.properties file to the build-logic build #177

Merged

Conversation

oheyadam
Copy link
Contributor

@oheyadam oheyadam commented Jul 15, 2022

This PR closes adds a gradle.properties to the build-logic build because the global properties aren't passed down to composite builds. Gradle issue here

I've set the following flags to true, but feel free to modify these properties further according to the project requirements down the line.

org.gradle.parallel=true
org.gradle.caching=true
org.gradle.configureondemand=true

This closes #167

Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and that initial set of properties also looks good!

@JolandaVerhoef JolandaVerhoef merged commit 68dbf8c into android:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Gradle properties are not passed down to included builds
3 participants