Fixed spacing for floating toolbar + back support #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The floating toolbar seen in expanded width windows was implemented as a sticky header. The problem with that is it allows the toolbar to go behind the status bar on scroll due to edge-to-edge. For a real sticky header, you'd probably want to implement inset handling into the header so that it sticks just below any insets. In this case, that would mean the toolbar never actually moves, so I pulled it out of sticky header and just put it as a sibling with the LazyColumn. By adding the safeDrawing insets, this keeps it positioned at the top right of the safeDrawing area. I also added a BackHandler for the drawer, so that pressing back closes the drawer. I don't see any clean way to implement predictive back with a modal navigation drawer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The floating toolbar seen in expanded width windows was implemented as a sticky header. The problem with that is it allows the toolbar to go behind the status bar on scroll due to edge-to-edge. For a real sticky header, you'd probably want to implement inset handling into the header so that it sticks just below any insets. In this case, that would mean the toolbar never actually moves, so I pulled it out of sticky header and just put it as a sibling with the LazyColumn. By adding the safeDrawing insets, this keeps it positioned at the top right of the safeDrawing area.
I also added a BackHandler for the drawer, so that pressing back closes the drawer. I don't see any clean way to implement predictive back with a modal navigation drawer.