Publish action package rename #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by running 'gradlew build -PuseMavenVersion=true'. Fixing an issue with module-info.java when building the repo straight from GitHub without the package rename. Modules don't like empty or non-existent packages. A new copy of module-info.java will be copied when building.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new package rename step needs to happen in the package action too.
build.gradle files have been updated to allow for building modern docking using the maven central packages instead of the local packages. This can be done as 'gradlew build -PuseMavenVersion=true'.
module-info.java files are now copied by the package renamer because having the new packages directly in the existing module-info.java causes compile issues with a fresh pull of the repo.