Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mr pipeline detection for child pipelines #610

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

andrcuns
Copy link
Owner

@andrcuns andrcuns commented Dec 11, 2023

When pipeline on Gitlab CI is a child pipeline, pipeline_source will not be merge_request_pipeline. Switch to checking for mr_iid as a more reliable way of detecting mr context


Test Report

allure-report-publisher generated test report!

rspec: ✅ test report for 04192682

+----------------------------------------------------------------+
|                       behaviors summary                        |
+-----------+--------+--------+---------+-------+-------+--------+
|           | passed | failed | skipped | flaky | total | result |
+-----------+--------+--------+---------+-------+-------+--------+
| helpers   | 129    | 0      | 0       | 0     | 129   ||
| commands  | 93     | 0      | 0       | 0     | 93    ||
| uploaders | 51     | 0      | 0       | 0     | 51    ||
| providers | 69     | 0      | 0       | 0     | 69    ||
| cli       | 3      | 0      | 0       | 0     | 3     ||
| generator | 6      | 0      | 0       | 0     | 6     ||
+-----------+--------+--------+---------+-------+-------+--------+
| Total     | 351    | 0      | 0       | 0     | 351   ||
+-----------+--------+--------+---------+-------+-------+--------+

@andrcuns andrcuns added the bug Something isn't working label Dec 11, 2023
Copy link

codeclimate bot commented Dec 11, 2023

Code Climate has analyzed commit 0419268 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.8% (0.0% change).

View more on Code Climate.

@andrcuns andrcuns merged commit cdb49e8 into main Dec 11, 2023
@andrcuns andrcuns deleted the fix-mr-detection branch December 11, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant