Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding gsutil for gcs uploads #409

Merged
merged 9 commits into from
Nov 7, 2022
Merged

Revert adding gsutil for gcs uploads #409

merged 9 commits into from
Nov 7, 2022

Conversation

andrcuns
Copy link
Owner

@andrcuns andrcuns commented Nov 7, 2022

gsutil is adding some unnecessary complexity and potential performance gains are not worth it. gsutil rsync method can also be very slow in some cases (when history file grows large)


Allure report

allure-report-publisher generated test report!

rspec: ✅ test report for 69719cdd

+----------------------------------------------------------------+
|                       behaviors summary                        |
+-----------+--------+--------+---------+-------+-------+--------+
|           | passed | failed | skipped | flaky | total | result |
+-----------+--------+--------+---------+-------+-------+--------+
| helpers   | 123    | 0      | 0       | 0     | 123   ||
| uploaders | 51     | 0      | 0       | 0     | 51    ||
| cli       | 3      | 0      | 0       | 0     | 3     ||
| providers | 48     | 0      | 0       | 0     | 48    ||
| commands  | 63     | 0      | 0       | 0     | 63    ||
| generator | 6      | 0      | 0       | 0     | 6     ||
+-----------+--------+--------+---------+-------+-------+--------+
| Total     | 294    | 0      | 0       | 0     | 294   ||
+-----------+--------+--------+---------+-------+-------+--------+

@andrcuns andrcuns added the maintenance Refactors and code improvements label Nov 7, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 7, 2022

Code Climate has analyzed commit 69719cd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.6% (0.2% change).

View more on Code Climate.

@andrcuns andrcuns force-pushed the chore-revert-gsutil branch from 9043502 to d363629 Compare November 7, 2022 10:36
@andrcuns andrcuns merged commit 0a5fa50 into main Nov 7, 2022
@andrcuns andrcuns deleted the chore-revert-gsutil branch November 7, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Refactors and code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant