Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report generation performance improvements #367

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Conversation

andrcuns
Copy link
Owner

@andrcuns andrcuns commented Sep 24, 2022

⚠️ Breaking change ⚠️

  • Removes filesystem copy operation which in case of large reports can significantly slow down report generation.

This changes --results-glob behaviour. It now must return a list of folders containing allure results instead of returning list of files.

Closes: #355


Allure report

allure-report-publisher generated test report!

rspec: ✅ test report for b8769b2a

+----------------------------------------------------------------+
|                       behaviors summary                        |
+-----------+--------+--------+---------+-------+-------+--------+
|           | passed | failed | skipped | flaky | total | result |
+-----------+--------+--------+---------+-------+-------+--------+
| commands  | 19     | 0      | 0       | 0     | 19    ||
| uploaders | 17     | 0      | 0       | 0     | 17    ||
| helpers   | 41     | 0      | 0       | 0     | 41    ||
| providers | 16     | 0      | 0       | 0     | 16    ||
| generator | 3      | 0      | 0       | 0     | 3     ||
| cli       | 1      | 0      | 0       | 0     | 1     ||
+-----------+--------+--------+---------+-------+-------+--------+
| Total     | 97     | 0      | 0       | 0     | 97    ||
+-----------+--------+--------+---------+-------+-------+--------+

@andrcuns andrcuns added the enhancement New enhancement label Sep 24, 2022
@andrcuns andrcuns changed the title ⚠️ Improve performance by not aggregating existing files in to temp directory ⚠️ ⚠️ Improve performance by not aggregating existing files in to temp directory Sep 24, 2022
@codeclimate
Copy link

codeclimate bot commented Sep 24, 2022

Code Climate has analyzed commit 64d04cd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.0% (0.0% change).

View more on Code Climate.

@andrcuns andrcuns changed the title ⚠️ Improve performance by not aggregating existing files in to temp directory ⚠️ Report generation performance improvements ⚠️ Sep 24, 2022
@andrcuns andrcuns changed the title ⚠️ Report generation performance improvements ⚠️ Report generation performance improvements Sep 24, 2022
@andrcuns andrcuns force-pushed the improvement-performance branch from b8769b2 to 910f50c Compare September 24, 2022 17:56
@andrcuns andrcuns force-pushed the improvement-performance branch from 086d91a to 64d04cd Compare September 24, 2022 18:11
@andrcuns andrcuns merged commit e5503cf into main Sep 24, 2022
@andrcuns andrcuns deleted the improvement-performance branch September 24, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance improvements
1 participant