-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action improvements, including coverage tests! #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rspier
commented
May 9, 2024
•
edited
Loading
edited
- Various cleanups of obsolete things from the workflow.
- Caching so we don't have to install modules each time (saves 2 minutes)
- Run Devel::Cover coverage tests and push results to Coveralls if the want-coverage label is applied.
- Explicitly use MariaDB, instead of whatever Debian's default is.
b15f84b
to
3588f9f
Compare
want-coverage
label is applied.
rjbs
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Took me a bit to make sure I understood it. I noted one very very small nit in git discipline.
…`want-coverage` label is applied.
…ymore. PAUSE no longer runs on v5.16, so we can use modern versions.
While they're written in perl, it's clearly the PAUSE test suite.
This shaves off 2 minutes of runtime. The cache key is based on the perl version and a hash of Makefile.PL, so adding new modules will trigger a flush.
The tests are no longer hanging, this doesn't seem to be a problem anymore.
This was referenced May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.