Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action improvements, including coverage tests! #508

Merged
merged 8 commits into from
May 12, 2024

Conversation

rspier
Copy link
Collaborator

@rspier rspier commented May 9, 2024

  • Various cleanups of obsolete things from the workflow.
  • Caching so we don't have to install modules each time (saves 2 minutes)
  • Run Devel::Cover coverage tests and push results to Coveralls if the want-coverage label is applied.
  • Explicitly use MariaDB, instead of whatever Debian's default is.

@rspier rspier force-pushed the coverage branch 2 times, most recently from b15f84b to 3588f9f Compare May 10, 2024 04:26
@rspier rspier changed the title Run Devel::Cover coverage tests and push results to Coveralls if the want-coverage label is applied. GitHub Action improvements, including coverage tests! May 10, 2024
@rspier rspier requested review from rjbs and wolfsage May 10, 2024 04:55
Copy link
Collaborator

@rjbs rjbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Took me a bit to make sure I understood it. I noted one very very small nit in git discipline.

rspier added 8 commits May 11, 2024 19:05
…ymore.

PAUSE no longer runs on v5.16, so we can use modern versions.
While they're written in perl, it's clearly the PAUSE test suite.
This shaves off 2 minutes of runtime.

The cache key is based on the perl version and a hash of Makefile.PL, so
adding new modules will trigger a flush.
The tests are no longer hanging, this doesn't seem to be a problem anymore.
@rspier rspier merged commit 31fca28 into andk:master May 12, 2024
2 checks passed
@rspier rspier deleted the coverage branch May 12, 2024 04:07
@rspier rspier restored the coverage branch May 12, 2024 04:31
@rspier rspier deleted the coverage branch May 18, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants