-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTVA-226 | Upgrade Node #153
base: tre-qa
Are you sure you want to change the base?
Conversation
4c91b34
to
e591f61
Compare
Refs TTVA-236
TTVA-236
Node Sass is no longer supported. Replace it with sass as recommended by the authors. Refs TTVA-236
Refs TTVA-236
Refs TTVA-236
Refs TTVA-236
UserReservationsPage test fails when run with test:ci command. Skip it for now. Refs TTVA-236, TTVA-241
Refs TTVA-236, TTVA-242
Refs TTVA-236, TTVA-242
Upgrade packages without breaking changes to the latest versions. Refs TTVA-236, TTVA-242
e591f61
to
54af4b0
Compare
@@ -5,7 +5,7 @@ import { shallowWithIntl } from '../../../utils/testUtils'; | |||
import { UnconnectedUserReservationsPage as UserReservationsPage } from '../UserReservationsPage'; | |||
import ReservationList from '../reservation-list/ReservationListContainer'; | |||
|
|||
describe('pages/user-reservations/UserReservationsPage', () => { | |||
xdescribe('pages/user-reservations/UserReservationsPage', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test (or whatever causes it to fail) should be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a commit with a fix.
Refs TTVA-236, TTVA-241
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Upgrade Node to v20
See TTVA-241 & TTVA-242 for changes that are related but will be done later.
Refs TTVA-226, TTVA-236