Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTVA-226 | Upgrade Node #153

Draft
wants to merge 12 commits into
base: tre-qa
Choose a base branch
from
Draft

TTVA-226 | Upgrade Node #153

wants to merge 12 commits into from

Conversation

japauliina
Copy link

@japauliina japauliina commented Mar 4, 2025

Upgrade Node to v20

  • Upgrade node in steps to v20.
  • Remove unused packages.
  • Replace node-sass with sass
  • Upgrade Jest.
  • Upgrade packages without breaking changes to the latest versions.

See TTVA-241 & TTVA-242 for changes that are related but will be done later.

Refs TTVA-226, TTVA-236

@japauliina japauliina force-pushed the TTVA-226-node-upgrade branch from 4c91b34 to e591f61 Compare March 7, 2025 08:11
Refs TTVA-236
Node Sass is no longer supported. Replace it with sass as recommended
by the authors.

Refs TTVA-236
Refs TTVA-236
Refs TTVA-236
UserReservationsPage test fails when run with test:ci command. Skip it
for now.

Refs TTVA-236, TTVA-241
Refs TTVA-236, TTVA-242
Refs TTVA-236, TTVA-242
Upgrade packages without breaking changes to the latest versions.

Refs TTVA-236, TTVA-242
@japauliina japauliina force-pushed the TTVA-226-node-upgrade branch from e591f61 to 54af4b0 Compare March 7, 2025 09:07
@japauliina japauliina requested a review from jopesy March 7, 2025 11:51
@@ -5,7 +5,7 @@ import { shallowWithIntl } from '../../../utils/testUtils';
import { UnconnectedUserReservationsPage as UserReservationsPage } from '../UserReservationsPage';
import ReservationList from '../reservation-list/ReservationListContainer';

describe('pages/user-reservations/UserReservationsPage', () => {
xdescribe('pages/user-reservations/UserReservationsPage', () => {
Copy link

@jopesy jopesy Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test (or whatever causes it to fail) should be fixed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit with a fix.

Refs TTVA-236, TTVA-241
Copy link

@jopesy jopesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants