Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update table sort to be name, version, type, severity, vulnerability #1400

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Jul 24, 2023

Update table sort in default presenter

This PR updates the table sort in the default table presenter with the following priority:

  • name
  • version
  • type
  • severity
  • vulnerability

Before the table output would have severities interleaved along with an unspecific ordering of CVE by date filed

Screenshot 2023-07-25 at 1 58 33 PM

After the table output now collates the results by severity (highest to lowest), further sorting those by when the CVE was filed (most recent year/number at the top)

Screenshot 2023-07-25 at 1 58 45 PM

TODO

  • Static Code linting
  • Update presenter tests to account for latest sort order

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs linked an issue Jul 24, 2023 that may be closed by this pull request
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs marked this pull request as ready for review July 25, 2023 18:27
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consistent sort order for grype output
2 participants