fix: vulnerabilities should be printed when --fail-on fails
#1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
willmurphyscode
commented
Jul 19, 2023
| "github.com/anchore/grype/internal/log" | ||
| ) | ||
|
|
||
| // eventLoop listens to worker errors (from execution path), worker events (from a partybus subscription), and | ||
| // signal interrupts. Is responsible for handling each event relative to a given UI an to coordinate eventing until | ||
| // an eventual graceful exit. | ||
| func eventLoop(workerErrs <-chan error, signals <-chan os.Signal, subscription *partybus.Subscription, cleanupFn func(), uxs ...clio.UI) error { | ||
| func eventLoop(workerErrs <-chan error, signals <-chan os.Signal, subscription *partybus.Subscription, cleanupFn func(), uxs ...clio.UI) error { //nolint:gocognit |
There was a problem hiding this comment.
Sorry for the nolint. I didn't see a great way to clean this up.
There was a problem hiding this comment.
I'm ok with this being nolint - it's legacy and meant to be stripped out eventually for the full cli refactor
--fail-on results in failure--fail-on fails
spiffcs
approved these changes
Jul 19, 2023
| @@ -54,6 +54,14 @@ func TestCmd(t *testing.T) { | |||
| assertInOutput("scope: all-layers"), | |||
| }, | |||
| }, | |||
| { | |||
| name: "vulnerabilities in output on -f with failure", | |||
There was a problem hiding this comment.
Nice thanks for the sanity check test here
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1392.