Port UI to bubbletea #1385
Merged
Port UI to bubbletea #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
kzantow
approved these changes
Jul 13, 2023
| } | ||
|
|
||
| // remove all whitespace padding from the end of the report | ||
| reports = append(reports, strings.TrimRight(report, "\n ")+"\n") |
There was a problem hiding this comment.
Would this be best to just directly output the report, unchanged? Maybe there happen to be some weird whitespace requirements? (I noticed Syft was changed this way, too, and the same comment applies there, probably more applicable to Syft)
There was a problem hiding this comment.
This makes the sender of the report not responsible for how they should look when conjoined with potentially other reports. That is the responsibility of the receiver / UI itself.
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This was referenced Jul 18, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to anchore/syft#1888, allowing ingestion of the new syft bubbletea handler as well as porting grype to using bubbletea components as well.
This nudges grype in the right direction for the cmd package layout as well, following the new patterns in quill. In doing so, all current
cmd/*.gosources have been moved tocmd/grype/cli/legacy/.Note: one notable change here is that this enables support for the TUI on windows 🎉