Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing constraint in v6 DB should match everything #503

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Missing constraint in v6 DB should match everything #503

merged 2 commits into from
Feb 18, 2025

Conversation

wagoodman
Copy link
Contributor

Changes:

  • missing version constraints should match all possible packages (which means an explicit range should be emitted)
  • warn when building a DB with a unique ecosystem (that grype might not know what to do with)

@wagoodman
missing constraint should match everything
71f27a3 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman
bump grype + fix linting
f40843e 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman marked this pull request as ready for review February 18, 2025 16:02
@wagoodman wagoodman enabled auto-merge (squash) February 18, 2025 16:04
kzantow
kzantow approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wagoodman wagoodman added the changelog-ignore Don't consider when generating the changelog label Feb 18, 2025
@wagoodman wagoodman merged commit 3fedee0 into main Feb 18, 2025
13 checks passed
@wagoodman wagoodman deleted the v6-fix-ecosystems branch February 18, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
changelog-ignore Don't consider when generating the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @kzantow