Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time-slot component on create-poll not working as expected on mobile #37

Closed
anandbaburajan opened this issue Jan 27, 2021 · 9 comments
Closed
Labels
bug Something isn't working dependencies

Comments

@anandbaburajan
Copy link
Owner

anandbaburajan commented Jan 27, 2021

The react-available-times component has some isses on mobile like not being able to adjust the interval or move the slots around. This would require some PRs at the react-available-times' upstream. It's quite old and throws some deprecation warnings too.

@anandbaburajan anandbaburajan added enhancement New feature or request help wanted Extra attention is needed labels Jan 27, 2021
@anandbaburajan anandbaburajan changed the title Time-slot-components not working as expected on mobile Ttime-slot component on create-poll not working as expected on mobile Jan 27, 2021
@VishnuSanal
Copy link

It would be great if the time slot component scrolls to the current time :)

@anandbaburajan anandbaburajan changed the title Ttime-slot component on create-poll not working as expected on mobile Time-slot component on create-poll not working as expected on mobile Feb 28, 2021
@anastr0
Copy link
Contributor

anastr0 commented Mar 9, 2021

@anandbaburajan @VipinVIP @BreadGenie What do you guys think of building a custom time-slot UI from scratch? Or utilise libraries like moment.js or moment-timezone.js to implement a custom UI? I feel like r-a-t could be a dead-end for us if need for more features in the future.

@anandbaburajan
Copy link
Owner Author

@anaswaratrajan that would require building a component similar to r-a-t plus more features from scratch. So what do you think about contributing to r-a-t and enhancing it instead?

@BreadGenie
Copy link
Contributor

@anaswaratrajan that would require building a component similar to r-a-t plus more features from scratch. So what do you think about contributing to r-a-t and enhancing it instead?

imo this is better unless the time slot component's evolution is supposed to be different from r-a-t
I'll start working on it after exams (add type and other stuff)

@BreadGenie
Copy link
Contributor

BreadGenie commented May 1, 2021

I was wondering on how to implement adjusting the interval and moving the slots for mobile devices. One idea that came to my mind would be to use press and hold (long press) and then drag either for adjusting the interval or for moving the slots.
Any other ideas?

@anandbaburajan
Copy link
Owner Author

I was wondering on how to implement adjusting the interval and moving the slots for mobile devices. One idea that came to my mind would be to use press and hold (long press) and then drag either for adjusting the interval or for moving the slots.

Thanks! Yep, this could work.

@anandbaburajan
Copy link
Owner Author

Updates: on mobile, only 1 hour slots can be created due to limitations in react-available-times. We would contribute to react-available-times but I think we should wait for some time to see how many users would want this to be fixed.

If you want to be able to select more than 1 hour slots on mobile, please let us know!

@anandbaburajan anandbaburajan removed the help wanted Extra attention is needed label Apr 2, 2022
@anandbaburajan
Copy link
Owner Author

Let's checkout https://github.com/jquense/react-big-calendar too

@anandbaburajan
Copy link
Owner Author

Let's checkout https://github.com/jquense/react-big-calendar too

Kukkee's using this now, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
None yet
Development

No branches or pull requests

4 participants