Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add support for and upgrade to Nx 18 #888

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Feb 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #883

What is the new behavior?

Generating a new Analog application within an Nx workspace works correctly with standalone or existing workspace.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 1cde579
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/65c934954f63210008f8af4c
😎 Deploy Preview https://deploy-preview-888--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 1cde579
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/65c93495deede200087d2573
😎 Deploy Preview https://deploy-preview-888--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 1cde579
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/65c934958399db0008d5c48f
😎 Deploy Preview https://deploy-preview-888--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 1cde579
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/65c93495c2cd350008fd636b
😎 Deploy Preview https://deploy-preview-888--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts force-pushed the build-nx-18-0-4 branch 3 times, most recently from 374ba76 to 3988c9c Compare February 11, 2024 20:31
@brandonroberts brandonroberts merged commit 180f358 into main Feb 11, 2024
23 checks passed
@brandonroberts brandonroberts deleted the build-nx-18-0-4 branch February 11, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create nx workspace with analogjs/platform as preset
1 participant