feat(nx-plugin): add support for nx 18 #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is what we needed. Thanks @joshuamorony |
brandonroberts
requested changes
Feb 8, 2024
packages/nx-plugin/src/generators/app/versions/nx_18_X/versions.ts
Outdated
Show resolved
Hide resolved
packages/nx-plugin/src/generators/app/versions/nx_18_X/versions.ts
Outdated
Show resolved
Hide resolved
brandonroberts
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Application generator fails when attempting to create a new Analog application in an Nx 18 workspace (installed Angular version is returning as
null)I don't actually know if this is the appropriate way to fix this or not, I was just trying to follow along with the patterns I found in the codebase. Please feel free to disregard this PR if it is not helpful.
Closes #
What is the new behavior?
Adds Nx 18 to app generator
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?