-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite-plugin-angular): add ability to export from .ng files #856
feat(vite-plugin-angular): add ability to export from .ng files #856
Conversation
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would go with export const routeMeta
and use ts-morph
to bring this to the targetSourceFile
instead of using defineMetadata
for it.
Thanks! @allcontributors add @joshuamorony for code |
I've put up a pull request to add @joshuamorony! 🎉 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
.ng format does not support defining a routeMeta
What is the new behavior?
This allows adding a
route
configuration todefineMetadata
e.g:Happy to modify how this is supplied - this seemed the most natural to me (I have also extended the window type to include the
RouteMeta
type forroute
).I assumed we didn't want to
export
the routeMeta in .ng files. Another option I considered was having a separatedefineRouteMetadata
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?