Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro-angular): check ComponentMirror before setting input #81

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

simitch1
Copy link
Contributor

@simitch1 simitch1 commented Sep 7, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog

What is the current behavior?

Right now the client side of the rendering doesn't check the ComponentMirror before setting the inputs of the angular component. Astro might add additional props that cause ng0303 error

Issue Number: #79

What is the new behavior?

Client rendering checks the ComponentMirror and sets the inputs only if they are defined on the component.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@brandonroberts
Copy link
Member

Is this ready for review?

@simitch1
Copy link
Contributor Author

simitch1 commented Sep 7, 2022

Is this ready for review?

Code is ok. I need more time, if requested, to add automated test with Playwright.

@brandonroberts
Copy link
Member

I think we're good to merge this. If you want to add another test we can do that in follow-up PR.

@brandonroberts brandonroberts marked this pull request as ready for review September 7, 2022 13:40
@brandonroberts brandonroberts merged commit c440629 into analogjs:main Sep 7, 2022
@simitch1 simitch1 deleted the fix/client-side-input branch September 7, 2022 14:41
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants