feat(astro-angular): add props (inputs) processing #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 31, 2022 00:26
- client: using `ComponentRef#setInput` - server: using `InjectionToken` with `providers` to pass static props to rendered Component via DI - add `astro-app` to test Astro integration ISSUE: analogjs#60
|
Some e2e smoke tests for the astro-app works for now. I'm not sure what the testing story is for integrations. I didn't find any in the source code for official Astro ones yet. |
Co-authored-by: Brandon <robertsbt@gmail.com>
|
Thanks! @allcontributors add @nartc for code, infra |
|
I've put up a pull request to add @nartc! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComponentRef#setInputBEFORE_APP_INITIALIZEDhook to runsetInputastro-appto test Astro integrationStill need to add some sort of tests for this feature. Any suggestions on how we'd want to test this?
ISSUE: #60