feat(astro-angular): enabled angular prod build #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure is probably because it needs the jest-preset-angular package for testing. We can switch to running the tests with Vitest and the Angular plugin |
|
Based on the Astro docs, this seems like the appropriate place to use this. https://docs.astro.build/en/reference/integrations-reference/#astrobuildsetup |
|
I switched from jest to vitest. Modified the tests and used the astro:build:setup hook instead of astro:build:start. |
|
Sorry about the miscommunication. I meant to post the build start link instead of the build setup one. I think either is suitable though so it can stay as is. |
|
Thanks a bunch! @allcontributors add @simitch1 for code |
|
I've put up a pull request to add @simitch1! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that to enable angular prod mode like requested in this issue #64 , we could simply use the astro:build:start or astro:build:setup hook to enable the prod compilation a single time.
I tried the build locally and seems to work, but I don't really know how to test further.
Before:
After:
Tests are failing right know but build is good. If the solution is ok I can work on it.
Let me know what do you think.