Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add mermaid dependency to new projects #570

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

The mermaid dependency is not installed when the Nx preset is used or installed with new projects.

Closes #

What is the new behavior?

The mermaid dependency is installed when the Nx preset is used or the creation of a new project.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 30fc789
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/64bfc3f381a1300008403c3f
😎 Deploy Preview https://deploy-preview-570--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 30fc789
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/64bfc3f3000bf800087d397b
😎 Deploy Preview https://deploy-preview-570--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 30fc789
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/64bfc3f3ed4e780008edbaea
😎 Deploy Preview https://deploy-preview-570--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 525c6c9 into main Jul 25, 2023
@brandonroberts brandonroberts deleted the fix-mermaid-nx branch July 25, 2023 13:01
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant