Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add config to be able to use component from libs and use it in … #261

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

goetzrobin
Copy link
Member

…analog-app

To ensure there is compatibility of Analog being used within an Nx workspace, the analog-app project in this repository is updated to use a library.
This includes installing vite-tsconfig-paths and updating the analog-apps vite.config.ts with the plugin and setting the root to the workspace root. This allows vite to pick up the workspace tsconfig.base.json, which includes the necessary mapping of the import url to the lib.

Closes #259

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Adds a lib-component and makes sure it is correctly picked up by analog-app

Which package are you modifying?

  • vite-angular-plugin
  • astro-angular
  • create-analog
  • router
  • platform
  • content

What is the current behavior?

Issue Number: 259

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 6cf486d
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/63e6db77fe94230008d72c82
😎 Deploy Preview https://deploy-preview-261--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@goetzrobin goetzrobin marked this pull request as ready for review February 10, 2023 23:46
@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 6cf486d
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/63e6db77ece4860008e599df
😎 Deploy Preview https://deploy-preview-261--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@goetzrobin goetzrobin force-pushed the feat-add-lib-to-analog-app branch from 9b56c37 to e05645e Compare February 10, 2023 23:49
@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 6cf486d
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/63e6db7773b8560008a80943
😎 Deploy Preview https://deploy-preview-261--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…analog-app

To ensure there is compatibility of Analog being used within an Nx
workspace, the analog-app project in this repository
is updated to use a library.
This includes installing vite-tsconfig-paths and updating the analog-apps
vite.config.ts with the plugin and setting the root to the workspace root.
This allows vite to pick up the workspace tsconfig.base.json, which
includes the necessary mapping of the import url to the lib.

Closes analogjs#259
@goetzrobin goetzrobin force-pushed the feat-add-lib-to-analog-app branch from e05645e to 6cf486d Compare February 11, 2023 00:04
@brandonroberts brandonroberts merged commit 7bc63e6 into analogjs:main Feb 11, 2023
Villanuevand pushed a commit to Villanuevand/analog that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Nx library to analog-app to ensure support for tsconfig paths
2 participants