Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: configure tsconfig.app.json location #129

Closed
1 of 2 tasks
marcjulian opened this issue Nov 8, 2022 · 1 comment
Closed
1 of 2 tasks

[FEAT]: configure tsconfig.app.json location #129

marcjulian opened this issue Nov 8, 2022 · 1 comment
Assignees
Labels
accepting PRs enhancement New feature or request

Comments

@marcjulian
Copy link
Contributor

Which scope/s are relevant/related to the feature request?

astro-angular

Information

I am using nx workspace together with @nxtensions/astro to generate an astro application into apps directory.

When using astro with @analogjs/astro-angular it requires a tsconfig.app.json at the root location. As this tsconfig is only required by astro-angular, it would be nice to change the location to the apps directory e.g. apps/website/tsconfig.app.ts.

@analogjs/vite-plugin-angular can be configured with PluginOptions which already allows to specify the tsconfig file.

Cloud @analogjs/astro-angular provide the PluginOptions passing them to @analogjs/vite-plugin-angular for configuration?

Describe any alternatives/workarounds you're currently using

Currently the tsconfig.app.json is required in the root directory.

One option is to keep the configuration in the astro project by creating the tsconfig.app.json in root pointing to a tsconfig.app.json in the astro project.

{
  "extends": "./apps/website/tsconfig.app.json"
}

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@marcjulian marcjulian added the enhancement New feature or request label Nov 8, 2022
@brandonroberts
Copy link
Member

Yep, that would be good to have. I just hadn't made the options available to the Astro integration yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PRs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants