Skip to content

Commit

Permalink
fix(vite-plugin-angular): apply babel transformations for safari 15 s… (
Browse files Browse the repository at this point in the history
  • Loading branch information
goetzrobin authored May 24, 2023
1 parent 1aeaaed commit 8ddb9ad
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@ import { loadEsmModule } from '@angular-devkit/build-angular/src/utils/load-esm'
import { transformAsync } from '@babel/core';
import angularApplicationPreset from '@angular-devkit/build-angular/src/babel/presets/application';

export function buildOptimizerPlugin({ isProd }: { isProd: boolean }): Plugin {
export function buildOptimizerPlugin({
isProd,
supportedBrowsers,
}: {
isProd: boolean;
supportedBrowsers: string[];
}): Plugin {
return {
name: '@analogjs/vite-plugin-angular-optimizer',
apply: 'build',
Expand All @@ -31,6 +37,8 @@ export function buildOptimizerPlugin({ isProd }: { isProd: boolean }): Plugin {
// NOTE: If esbuild adds support in the future, the babel support for these can be disabled.
'async-generator': false,
'for-await': false,
'class-field': false,
'class-static-field': false,
},
},
};
Expand Down Expand Up @@ -78,6 +86,7 @@ export function buildOptimizerPlugin({ isProd }: { isProd: boolean }): Plugin {
linkerPluginCreator,
},
forceAsyncTransformation,
supportedBrowsers,
optimize: isProd && {
looseEnums: angularPackage,
pureTopLevel: angularPackage,
Expand Down
7 changes: 5 additions & 2 deletions packages/vite-plugin-angular/src/lib/angular-vite-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function angular(options?: PluginOptions): Plugin[] {
options?.advanced?.tsTransformers?.afterDeclarations ?? [],
},
},
supportedBrowsers: options?.supportedBrowsers ?? ['iOS <=15'],
supportedBrowsers: options?.supportedBrowsers ?? ['safari 15'],
jit: options?.jit,
};

Expand Down Expand Up @@ -350,7 +350,10 @@ export function angular(options?: PluginOptions): Plugin[] {
jitPlugin({
inlineStylesExtension: pluginOptions.inlineStylesExtension,
})) as Plugin,
buildOptimizerPlugin({ isProd }),
buildOptimizerPlugin({
isProd,
supportedBrowsers: pluginOptions.supportedBrowsers,
}),
].filter(Boolean) as Plugin[];

function setupCompilation() {
Expand Down

0 comments on commit 8ddb9ad

Please sign in to comment.