Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Other, PeriphDrivers): Fix MAX32657 build issue #1173

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

ozersa
Copy link
Contributor

@ozersa ozersa commented Sep 12, 2024

This PR apply fix for MAX32657 zephyr.

  • MXC_SYS_LockDAP_Permanent should be called only for secure mode
  • Empty partition_max32657.h file added to it build on zephyr side as it is

image

image

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

- MXC_SYS_LockDAP_Permanent should be called only for secure mode
- Empty partition_max32657.h file added to it build on zephyr side as it is

Signed-off-by: Sadik Ozer <sadik.ozer@analog.com>
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozersa do you think it's reasonable to start integrating Zephyr build testing into the MSDK?

I'm not sure what's involved, but it would be useful to catch these issues now that the HAL is starting to grow

@Jake-Carter Jake-Carter merged commit 937bdf7 into main Sep 12, 2024
8 of 9 checks passed
@Jake-Carter Jake-Carter deleted the fix/max32657_build_issues branch September 12, 2024 18:32
@ozersa
Copy link
Contributor Author

ozersa commented Sep 13, 2024

@ozersa do you think it's reasonable to start integrating Zephyr build testing into the MSDK?

I'm not sure what's involved, but it would be useful to catch these issues now that the HAL is starting to grow

Good idea, it is already doing by internal zephyr repository, If we do it for MSDK to it will have multiple dependency limitation that need to be handled, we will think on it.... @MaureenHelm

@ozersa
Copy link
Contributor Author

ozersa commented Sep 13, 2024

Not critical but additionally, if upstream action been canceled by somehow, the PR content is being pushed by other PR that cause confliction while reviewing.

For example below this commit been pushed by PR#1171 instead PR#1173,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants