fix(PeriphDrivers): Leaving UART HE interrupt disabled during initial fill. #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevent un-intended interrupts, causing txCnt to exceend txLen.
Jake-Carter
approved these changes
Aug 27, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Aug 27, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
ozersa
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevent un-intended interrupts, causing txCnt to exceend txLen. If the HE interrupt is enabled while we're filling the FIFO, then we can get the interrupt while we're filling. This interrupts the filling process, leading to txCnt exceeding txLen.
This is only an issue in the initial fill, since we're probably not in the interrupt context. When we're in the interrupt context, we may get another HE interrupt flag from the UART, but it won't interrupt the CPU, and we clear the flag after completing the fill.
Checklist Before Requesting Review