chore(Other): Update Zephyr DMA wrapper for MAX32657 #1027
Conversation
671318c to
cd87ec0
Compare
| #if defined(CONFIG_SOC_MAX32657) || (CONFIG_SOC_MAX32665) || (CONFIG_SOC_MAX32666) | ||
|
|
||
| #if defined(CONFIG_SOC_MAX32657) | ||
| #define ADI_MAX32_DMA_CTRL_DIS_IE MXC_F_DMA_CTRL_DIS_IE | ||
| #define ADI_MAX32_DMA_CTRL_CTZIEN MXC_F_DMA_CTRL_CTZ_IE | ||
|
|
||
| #define ADI_MAX32_DMA_STATUS_IPEND MXC_F_DMA_STATUS_IPEND | ||
| #define ADI_MAX32_DMA_STATUS_BUS_ERR MXC_F_DMA_STATUS_BUS_ERR | ||
| #define ADI_MAX32_DMA_STATUS_TO_IF MXC_F_DMA_STATUS_TO_IF | ||
| #define ADI_MAX32_DMA_STATUS_ST MXC_F_DMA_STATUS_STATUS | ||
|
|
||
| #define ADI_MAX32_DMA_CFG_REQ_POS MXC_F_DMA_CTRL_REQUEST_POS |
There was a problem hiding this comment.
The MAX32657 DMA IP source is MAX32655,
MAX32657 and MAX32655 register map and register names are exactly match, MAX32657 has two DMA this causes API function changes,
The reason we have this dma wrapper is because of there were two group MCUs, one group has multiple DMA and other group has one DMA but with new IP block. MAX32657 bring a third group which has multiple DMA and new IP block.
So that instead of adding MAX32657 as this I prefer totally removing device groups, to simplify file content.
Please check below file.
wrap_max32_dma.md
- Removed device groups. - Added wrapper version of 'MXC_DMA_EnableInt' due to MSDK driver's changes. Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
cd87ec0 to
7f677eb
Compare
There was a problem hiding this comment.
@sihyung-maxim FYI the DMA API variations (#1008) also need to be addressed in the Zephyr HAL and are becoming more difficult to change/remove
Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
This reverts commit 09a77db.
Description
MAX32657 driver functions require DMA instances. Because of that, I moved it into MAX32665/6 section. Also, I moved necessary register macros for MAX32657 into this section.
I added wrapper version of 'MXC_DMA_EnableInt' due to MSDK driver's changes.
Checklist Before Requesting Review