-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do t.storage.Flush() on torrent completion, and on storage.Close() #755
Merged
anacrolix
merged 22 commits into
anacrolix:master
from
AskAlexSharov:fsync_on_file_finish
Jul 7, 2022
Merged
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
03714df
do t.storage.Flush() when torrent completion happen. And when storage…
AskAlexSharov 82f028f
do t.storage.Flush() when torrent completion happen. And when storage…
AskAlexSharov 78741df
check nil on caller
AskAlexSharov b22e5c0
clean
AskAlexSharov f6b0733
Merge branch 'master' into fsync_on_file_finish
AskAlexSharov 842f561
FlushAsync method
AskAlexSharov 32d3086
FlushAsyncAt method
AskAlexSharov 259201f
FlushAsyncAt method
AskAlexSharov 320081c
FlushAsyncAt method
AskAlexSharov 2acf848
FlushAsyncAt method
AskAlexSharov 8af4a58
FlushAsyncAt method
AskAlexSharov 6e9f2d0
FlushAsyncAt method
AskAlexSharov d091a27
Merge branch 'master' into fsync_on_file_finish
AskAlexSharov df962eb
save
AskAlexSharov eaa4a6e
save
AskAlexSharov 0c79727
save
AskAlexSharov 9e69d94
save
AskAlexSharov cf9f013
save
AskAlexSharov a79295e
save
AskAlexSharov e454c69
Merge branch 'master' into fsync_on_file_finish
AskAlexSharov ce57a48
save
AskAlexSharov a4a87d5
save
AskAlexSharov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be a more suitable place to put this, there should be a method that's only called when torrent completion transitions to complete from incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I don't see such method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see the confusion. This flushes the entire torrent, when the entire torrent is complete. Do you want perhaps flush the individual memory-maps, when associated pieces become complete? That would be a more gradual approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not spotting this before. Similarly, if this was the approach, the Flush would move on to the piece implementation. Let me know your thoughts.