Fix possible misuse of reflect.StringHeader

anacrolix · Sep 9, 2021 · 5cb4702 · 5cb4702
1 parent 1fc6093
commit 5cb4702
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/bencode/misc.go b/bencode/misc.go
@@ -21,8 +21,10 @@ func bytesAsString(b []byte) string {
 	if len(b) == 0 {
 		return ""
 	}
-	return *(*string)(unsafe.Pointer(&reflect.StringHeader{
-		uintptr(unsafe.Pointer(&b[0])),
-		len(b),
-	}))
+	// See https://github.com/golang/go/issues/40701.
+	var s string
+	hdr := (*reflect.StringHeader)(unsafe.Pointer(&s))
+	hdr.Data = uintptr(unsafe.Pointer(&b[0]))
+	hdr.Len = len(b)
+	return s
 }