Use uint32 atomics #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int64 atomics are not supported on 32-bit systems as of now: golang/go#599
|
I suspect you've encoutered this despite fd60ad0 due to anacrolix/torrent#483 (comment)? |
Yessir: I tested on the latest master commit at the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int64 atomics are not supported on 32-bit systems as of now: golang/go#599. I doubt the changed variables will ever exceed UINT32_MAX
I tested this on an x86-32 system with success. I'll make a write-up on the necessary configurations to run anacrolix/torrent (v1.30.0 as of the time of writing) on Android. @anacrolix, please let me know if you need this before approving the PR.
Many thanks for the fantastic project ❤️