Supporting Neptune in the Databuilder #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew <andrjc4@vt.edu>
|
cc @friendtocephalopods to take a look |
|
the rfc lgtm |
rfcs/000-neptune-support.md
Outdated
| @@ -0,0 +1,61 @@ | |||
| - Feature Name: Amazon Neptune Databuilder support | |||
| - Start Date: 2020-11-10 | |||
| - RFC PR: [amundsen-io/rfcs#0000](https://github.com/amundsen-io/rfcs/pull/0000) (after opening the RFC PR, update this with a link to it and update the file name) | |||
There was a problem hiding this comment.
tiny nit, I think we should update this?
|
LGTM! |
Golodhros
reviewed
Nov 12, 2020
rfcs/000-neptune-support.md
Outdated
| @@ -0,0 +1,61 @@ | |||
| - Feature Name: Amazon Neptune Databuilder support | |||
| - Start Date: 2020-11-10 | |||
| - RFC PR: [amundsen-io/rfcs#0000](https://github.com/amundsen-io/rfcs/pull/0000) (after opening the RFC PR, update this with a link to it and update the file name) | |||
There was a problem hiding this comment.
Suggested change
| - RFC PR: [amundsen-io/rfcs#0000](https://github.com/amundsen-io/rfcs/pull/0000) (after opening the RFC PR, update this with a link to it and update the file name) | |
| - RFC PR: [amundsen-io/rfcs#13](https://github.com/amundsen-io/rfcs/pull/13) |
Golodhros
reviewed
Nov 12, 2020
rfcs/000-neptune-support.md
Outdated
| - Feature Name: Amazon Neptune Databuilder support | ||
| - Start Date: 2020-11-10 | ||
| - RFC PR: [amundsen-io/rfcs#0000](https://github.com/amundsen-io/rfcs/pull/0000) (after opening the RFC PR, update this with a link to it and update the file name) | ||
| - Amundsen Issue: [amundsen-io/amundsen#0000](https://github.com/amundsen-io/amundsen/issues/0000) (leave this empty for now) |
There was a problem hiding this comment.
Let's create this issue on the issue tracker of Amundsen
|
Seems to be acceptance of this proposal, moving it to FCP |
Signed-off-by: Andrew <andrjc4@vt.edu>
Signed-off-by: Andrew <andrjc4@vt.edu>
2 tasks
3 tasks
allisonsuarez
pushed a commit
that referenced
this pull request
Feb 23, 2021
* RFC for adding Neptune support to the Databuilder. Signed-off-by: Andrew <andrjc4@vt.edu> * Fix typos Signed-off-by: Andrew <andrjc4@vt.edu> * update with pr info Signed-off-by: Andrew <andrjc4@vt.edu> * update with pr info Signed-off-by: Andrew <andrjc4@vt.edu> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
pushed a commit
that referenced
this pull request
May 5, 2021
* RFC for adding Neptune support to the Databuilder. Signed-off-by: Andrew <andrjc4@vt.edu> * Fix typos Signed-off-by: Andrew <andrjc4@vt.edu> * update with pr info Signed-off-by: Andrew <andrjc4@vt.edu> * update with pr info Signed-off-by: Andrew <andrjc4@vt.edu> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.