Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser sdk storage #483

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: browser sdk storage #483

merged 1 commit into from
Jan 24, 2025

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Jan 23, 2025

AMP-122389

Fix: amplitude/Amplitude-JavaScript#614

  • config.storage in JS SDK is for metadata, equivalent to config.identityStorage in Browser 2.0 SDK
  • Add missing session storage for config.identityStorage in Browser 2.0 SDK

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs ✅ Ready (Inspect) Visit Preview Jan 23, 2025 11:45pm

@Mercy811 Mercy811 merged commit 548b5c8 into main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting storage to 'none' still sets some local storage values
2 participants