fix issue of whitespace around for expressions #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the parser would error if whitespace was included after the => in a for expression like the one I added to the tests.
|
I just realized this is a dupe of #85, but mine includes tests. |
|
Any chance we can get this or #85 merged? |
aoskotsky-amplify
approved these changes
Feb 21, 2022
|
Thanks for the PR! |
Closed
ryanking
added a commit
to ryanking/pants
that referenced
this pull request
Feb 22, 2022
This release fixes a bug I encountered and fixed: amplify-education/python-hcl2#87
This was referenced Feb 22, 2022
ryanking
added a commit
to ryanking/pants
that referenced
this pull request
Feb 22, 2022
This release fixes a bug I encountered and fixed: amplify-education/python-hcl2#87
ryanking
added a commit
to ryanking/pants
that referenced
this pull request
Feb 23, 2022
This release fixes a bug I encountered and fixed: amplify-education/python-hcl2#87 [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Feb 23, 2022
This release fixes a bug I encountered and fixed: amplify-education/python-hcl2#87 [ci skip-rust] [ci skip-build-wheels]
alonsodomin
pushed a commit
to alonsodomin/pants
that referenced
this pull request
Feb 25, 2022
This release fixes a bug I encountered and fixed: amplify-education/python-hcl2#87 [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the parser would error if whitespace was included after
the => in a for expression like the one I added to the tests.