handle one line blocks as regular blocks #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jconstance-amplify , @aoskotsky-amplify |
Handle indexes of lists with more than 10 items
Handle dot index
Handle dot index
kapilt
reviewed
Aug 22, 2020
| @@ -0,0 +1,67 @@ | |||
| name: build | |||
There was a problem hiding this comment.
this shouldn't be in this pr, its unrelated to the functionality of the fix, ie. its switching ci
There was a problem hiding this comment.
Yep. My bad. After waiting to get this one merged I created a temporal fork. Would gladly drop it when if the other changes in the PR looks good to the maintainers.
kapilt
reviewed
Aug 22, 2020
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "python-hcl2", | |||
| "name": "bc-python-hcl2", | |||
There was a problem hiding this comment.
your referencing your fork, instead of the upstream your contributing to.
kapilt
reviewed
Aug 22, 2020
| @@ -35,7 +35,7 @@ def get_requirements(): | |||
|
|
|||
|
|
|||
| setup( | |||
| name='python-hcl2', | |||
| name='bc-python-hcl2', | |||
There was a problem hiding this comment.
your referencing your fork, instead of the upstream your contributing to.
|
Merged this as part of #45. Thanks for sending this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse one-line-blocks as regular blocks, so the parser's output for both types of blocks would be the same (values nested in lists)
Solves bridgecrewio/checkov#452
@aoskotsky-amplify