Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DictTransformer - do not wrap type literals into ${ and } #186

Merged
merged 1 commit into from
Jan 24, 2025
Merged

DictTransformer - do not wrap type literals into ${ and } #186

merged 1 commit into from
Jan 24, 2025

Conversation

kkozik-amplify
Copy link
Collaborator

@kkozik-amplify kkozik-amplify commented Jan 23, 2025 •
edited
Loading

  • make an exception for bool, number and string literals to not be wrapped into string dollars
  • add unit tests for the above

this fixes #179

@kkozik-amplify kkozik-amplify marked this pull request as ready for review January 23, 2025 16:00
@kkozik-amplify kkozik-amplify requested a review from a team as a code owner January 23, 2025 16:00
rddimon
rddimon reviewed Jan 23, 2025
View reviewed changes
hcl2/transformer.py Outdated Show resolved Hide resolved
@kkozik-amplify kkozik-amplify force-pushed the fix/type-literals-transformation branch from 5573060 to 8bcd9fd Compare January 23, 2025 17:22
@kkozik-amplify kkozik-amplify merged commit 7afa933 into main Jan 24, 2025
12 checks passed
@kkozik-amplify kkozik-amplify deleted the fix/type-literals-transformation branch January 24, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rddimon rddimon rddimon approved these changes

@aoskotsky-amplify aoskotsky-amplify Awaiting requested review from aoskotsky-amplify

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transforming a .tf file into .tf.json returns wrong types
2 participants
@kkozik-amplify @rddimon