Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty heredoc and fix catastrophic backtracking issue #117

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Support empty heredoc and fix catastrophic backtracking issue #117

merged 3 commits into from
Jan 10, 2023

Conversation

htorianik
Copy link
Contributor

Fix of #101

@htorianik htorianik added the bug Something isn't working label Jan 10, 2023
@htorianik htorianik requested a review from a team January 10, 2023 11:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2023
View reviewed changes
hcl2/transformer.py Fixed Show fixed Hide fixed
hcl2/transformer.py Fixed Show fixed Hide fixed
@rddimon rddimon linked an issue Jan 10, 2023 that may be closed by this pull request
Unexpected token exception on empty heredoc #101
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2023
View reviewed changes
hcl2/transformer.py Fixed Show fixed Hide fixed
hcl2/transformer.py Fixed Show fixed Hide fixed
@htorianik htorianik force-pushed the feature/empty-heredoc branch from 5c7e361 to ae313a0 Compare January 10, 2023 13:30
@htorianik htorianik changed the title Support empty heredoc. Support empty heredoc and fix catastrophic backtracking issue Jan 10, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2023
View reviewed changes
hcl2/transformer.py Fixed Show fixed Hide fixed
hcl2/transformer.py Fixed Show fixed Hide fixed
@htorianik htorianik force-pushed the feature/empty-heredoc branch from ae313a0 to 5c96547 Compare January 10, 2023 14:09
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2023
View reviewed changes
hcl2/transformer.py Fixed Show fixed Hide fixed
hcl2/transformer.py Fixed Show fixed Hide fixed
@htorianik htorianik force-pushed the feature/empty-heredoc branch from 5c96547 to ad657dd Compare January 10, 2023 14:29
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2023
View reviewed changes
hcl2/transformer.py Fixed Show fixed Hide fixed
hcl2/transformer.py Fixed Show fixed Hide fixed
@htorianik htorianik merged commit 59602e3 into master Jan 10, 2023
@htorianik htorianik deleted the feature/empty-heredoc branch January 10, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoskotsky-amplify aoskotsky-amplify aoskotsky-amplify approved these changes

@rddimon rddimon rddimon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected token exception on empty heredoc
4 participants
@htorianik @rddimon @aoskotsky-amplify @htorianik-amplify