New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `weakClosure()` not preserving original scope #393

Merged

trowski merged 1 commit into amphp:v3 from Nevay:fix/weakclosure-keep-original-scope

Jun 25, 2022

Contributor

Nevay commented Jun 24, 2022

Changes weakClosure() to preserve original closure scope by using ::bindTo() instead of ::call() if scope differs from $this class.


          Fix weakClosure() not preserving original scope

0c59846

trowski merged commit 9579bc7 into amphp:v3

Member

trowski commented Jun 25, 2022

Thanks for finding and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet