Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for 32 bit systems? #252

Closed
gharlan opened this issue Dec 17, 2018 · 12 comments
Closed

support for 32 bit systems? #252

gharlan opened this issue Dec 17, 2018 · 12 comments

Comments

@gharlan
Copy link

gharlan commented Dec 17, 2018

Do you want to support 32bit systems?

I tried to use artax on an older server, but it does not work.
The return value of getCurrentTime is too big for 32bit, so the return value is a negative int.

And in this line an error is thrown, because argument 2 is smaller than argument 1.

@kelunik
Copy link
Member

kelunik commented Dec 17, 2018

I guess you're using PHP 7.3?

@kelunik kelunik closed this as completed Dec 17, 2018
@kelunik kelunik reopened this Dec 17, 2018
@gharlan
Copy link
Author

gharlan commented Dec 17, 2018

No, 7.2.

@kelunik
Copy link
Member

kelunik commented Dec 19, 2018

Does everything work fine with versions < 2.1?

@mstrouhal
Copy link

mstrouhal commented Mar 18, 2019

@kelunik Yes, it does. Problem started to occur after update do 2.1 version.
(PHP 7.2)

microtime(true) * 1000 is higher than PHP_INT_MAX, which is 2147483647

@qq15870939565
Copy link

How did you deal with this problem, I also encountered

@mstrouhal
Copy link

The only solution I have found so far is to require older version of amp:

"amphp/amp": "2.0.7"

@qq15870939565
Copy link

qq15870939565 commented May 21, 2019 via email

@trowski
Copy link
Member

trowski commented May 21, 2019

I pushed a commit to the fix-252 branch. Please try this on a 32-bit system and let me know if it fixes the problem.

@tunnela
Copy link

tunnela commented May 26, 2019

@trowski it fixes the problem 👍

@kelunik
Copy link
Member

kelunik commented May 31, 2019

@gharlan @tunnela @qq15870939565 Please test with the latest master.

@qq15870939565
Copy link

qq15870939565 commented Jun 2, 2019 via email

@kelunik
Copy link
Member

kelunik commented Jun 10, 2019

Released a bugfix version, please report if there are further issues.

@kelunik kelunik closed this as completed Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants