Update subproject clean targets with absolute paths #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglook
reviewed
Aug 21, 2024
test/lein_monolith/config_test.clj
Outdated
There was a problem hiding this comment.
🤔 I initially thought the test would be checking that lein monolith each clean would remove the correct local directory in the example project.
There was a problem hiding this comment.
I can add that, I was biased toward testing the immediate change initially
greglook
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
I was thinking of a script-level example test but this is better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a command like
lein monolith each do clean, install, any subprojects that provide relative paths for their clean targets will clean from the working directory that lein monolith was called from, instead of the root of the subproject (see technomancy/leiningen#2707). Leiningen seems to handle relative paths for other config values like target path and source path, but seems like clean targets is the odd one out.We can work around this issue by prepending the clean target paths with the root of the subproject as we're loading the project maps, which seems ok enough to me.
Tested this by adding a unit test, and also confirmed that
lein monolith each cleancleans the right directories after this change.